fix(@angular/cli): update yarn berry package manager configuration #32206
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the package manager descriptor for modern Yarn (Berry) to align with its current CLI options and configuration mechanisms: - Removes `noLockfileFlag` as Yarn Berry does not support a direct `--no-lockfile` flag for adding packages. - Updates `ignoreScriptsFlag` to use `--mode=skip-build`, which is the modern equivalent for skipping build scripts during installation. - Changes `getRegistryOptions` to use `YARN_NPM_REGISTRY_SERVER` environment variable, which is the correct way to configure the registry in Yarn Berry.
This commit updates `parseNpmLikeManifest` to correctly handle the output of `npm view` (and compatible commands) when a version range is specified. In such cases, `npm view --json` returns an array of manifests. The parser now returns the last element of the array, which corresponds to the latest version satisfying the range, preventing issues in `ng update` and other commands that rely on version checks.
clydin
added
the
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the package manager descriptor for modern Yarn (Berry) to align with its current CLI options and configuration mechanisms:
noLockfileFlagas Yarn Berry does not support a direct--no-lockfileflag for adding packages.ignoreScriptsFlagto use--mode=skip-build, which is the modern equivalent for skipping build scripts during installation.getRegistryOptionsto useYARN_NPM_REGISTRY_SERVERenvironment variable, which is the correct way to configure the registry in Yarn Berry.